Remove unnecessary generics from encode and decode functions #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RecordBatchEncoder::encode
andRecordBatchEncoder::decode
functions have a generic for the compression function closure.This makes calling these APIs require naming these generics, when this is not necessary.
For example, to call
RecordBatchDecoder::decode
, you have to do this:Or you get this error:
We can remove the generic for the closure and the compiler can now infer the types: