Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'None' error type #78

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow 'None' error type #78

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cda25c5
Allow 'None' error type
pdeva Sep 12, 2024
305f38f
Merge branch 'main' into patch-1
pdeva Sep 13, 2024
fa0a496
fix try_from_code
pdeva Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,7 @@ macro_rules! define_errors {
#[doc = "Returns `None` if the error `code` is `0`."]
#[doc = concat!("Otherwise, the `Some(", stringify!($name), ")` is returned.")]
pub fn try_from_code(code: i16) -> Option<Self> {
match code {
0 => None,
match code {
$(
$code => Some($name::[<$kind:camel>]),
)*
Expand Down Expand Up @@ -185,7 +184,7 @@ macro_rules! define_errors {

define_errors! { ResponseError,
(UNKNOWN_SERVER_ERROR, -1, false, "The server experienced an unexpected error when processing the request."),
// (NONE, 0, false, "No error"),
(NONE, 0, false, "No error"),
(OFFSET_OUT_OF_RANGE, 1, false, "The requested offset is not within the range of offsets maintained by the server."),
(CORRUPT_MESSAGE, 2, true, "This message has failed its CRC checksum, exceeds the valid size, has a null key for a compacted topic, or is otherwise corrupt."),
(UNKNOWN_TOPIC_OR_PARTITION, 3, true, "This server does not host this topic-partition."),
Expand Down
Loading