Skip to content

Use GET and support custom slugs #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Use GET and support custom slugs #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 48 additions & 19 deletions index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,9 @@
}

if($_SERVER['REQUEST_URI'] == '/') { doNothing(); exit; }
if($pw_stats == '' && preg_match('!^/stats(/?.*)$!', $_SERVER['REQUEST_URI']) == 1) { stats(); exit; }
if($pw_stats != '' && preg_match('!^/stats/' . preg_quote($pw_stats, '!') . '/?$!', $_SERVER['REQUEST_URI']) == 1) { stats(); exit; }
if(preg_match('!^/stats(/?.*)$!', $_SERVER['REQUEST_URI']) == 1) { stats(); exit;}
if(preg_match("!^/[$valid_chars]+/?$!", $_SERVER['REQUEST_URI']) == 1) { processSlug(); exit; }
if($pw_stats == '' && preg_match("!^/[$valid_chars]+/stats/?$!", $_SERVER['REQUEST_URI']) == 1) { slugStats(); exit; }
if($pw_stats != '' && preg_match("!^/[$valid_chars]+/stats/" . preg_quote($pw_stats, '!') . "/?$!", $_SERVER['REQUEST_URI']) == 1) { slugStats(); exit; }
if($pw_create == '' && preg_match("!^/[a-z0-9]+://.+$!", $_SERVER['REQUEST_URI']) == 1) { createLink(); exit; }
if($pw_create != '' && preg_match("!^/" . preg_quote($pw_create, '!') . "/[a-z0-9]+://.+$!", $_SERVER['REQUEST_URI']) == 1) { createLink(); exit; }
if(preg_match('!^/create(/?.*).+$!', $_SERVER['REQUEST_URI']) == 1) { createLink(); exit; }

exit;

Expand Down Expand Up @@ -59,24 +55,42 @@ function processSlug() {
function createLink() {
global $base_url, $random_chars, $slug_length, $db, $pw_create, $accepts_json;

$url = ltrim($_SERVER['REQUEST_URI'], '/');
$url = isset($_POST['url']) ? '' : $_GET['url'];
$custom_slug = isset($_POST['slug']) ? '' : $_GET['slug'];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$custom_slug should be escaped before it's used in mysql_query on lines 84 and 97.

Suggested change
$custom_slug = isset($_POST['slug']) ? '' : $_GET['slug'];
$custom_slug = mysqli_real_escape_string($db, isset($_POST['slug']) ? '' : $_GET['slug']);

$password = isset($_POST['password']) ? '' : $_GET['password'];

if($pw_create != '') {
$url = preg_replace('!^'. preg_quote($pw_create, '!') . '/(.+)$!', '$1', $url);
if($pw_create != $password) {
error('incorrect password', 403);
exit;
}
}

do {
$possible_slug = '';
for($i = 0; $i < $slug_length; $i++) {
$possible_slug .= $random_chars[rand(0, strlen($random_chars) - 1)];
}
$result = mysqli_query($db, "SELECT COUNT(*) FROM links WHERE slug = '$possible_slug'") or error('Could not generate new slug.', 500);
if($custom_slug == '') {
do {
$possible_slug = '';
for($i = 0; $i < $slug_length; $i++) {
$possible_slug .= $random_chars[rand(0, strlen($random_chars) - 1)];
}
$result = mysqli_query($db, "SELECT COUNT(*) FROM links WHERE slug = '$possible_slug'") or error('Could not generate new slug.', 500);
$row = mysqli_fetch_row($result);
$count = $row[0];
if($count == 0) {
$slug = $possible_slug;
}
} while(is_null($slug));
}
else {
$result = mysqli_query($db, "SELECT COUNT(*) FROM links WHERE slug = '$custom_slug'") or error('Could not generate new slug.', 500);
$row = mysqli_fetch_row($result);
$count = $row[0];
if($count == 0) {
$slug = $possible_slug;
$slug = $custom_slug;
}
else {
error('slug already used', 409);
}
} while(is_null($slug));
}

$escaped_url = mysqli_real_escape_string($db, $url) or error('Could not escape URL.', 500);

Expand All @@ -94,6 +108,19 @@ function createLink() {
function stats() {
global $db, $base_url, $pw_stats, $accepts_json;

$password = isset($_POST['password']) ? '' : $_GET['password'];
$slug = isset($_POST['slug']) ? '' : $_GET['slug'];

if($pw_stats != '' && $pw_stats != $password) {
error('incorrect password', 403);
exit;
}

if($slug != '') {
slugStats();
exit();
}

$data = array();

$result = mysqli_query($db, 'SELECT * FROM links ORDER BY created DESC LIMIT 50') or error('Could not fetch recent URLs.', 500);
Expand Down Expand Up @@ -141,7 +168,7 @@ function stats() {
$s = $link['top_referer']['visits'] == 1 ? '' : 's';
echo "<td><a href='" . $link['top_referer']['domain'] . "'>" . $link['top_referer']['domain'] . "</a> (" . $link['top_referer']['visits'] . " visit$s)</td>";
}
echo "<td><a href='/{$link['slug']}/stats/$pw_stats'>View Stats</a></td>";
echo "<td><a href='/stats?slug={$link['slug']}&password=$pw_stats'>View Stats</a></td>";
echo "</tr>";
}
echo "</tbody>";
Expand All @@ -152,9 +179,11 @@ function stats() {
function slugStats() {
global $db, $pw_stats, $valid_chars, $accepts_json;

$slug = trim($_SERVER['REQUEST_URI'], '/');
$slug = preg_replace("!^([$valid_chars]+)/stats.*$!", '$1', $slug);
#$slug = trim($_SERVER['REQUEST_URI'], '/');
#$slug = preg_replace("!^([$valid_chars]+)/stats.*$!", '$1', $slug);

$slug = isset($_POST['slug']) ? '' : $_GET['slug'];

$escaped_slug = mysqli_real_escape_string($db, $slug);
$result = mysqli_query($db, "SELECT * FROM links WHERE slug = '$escaped_slug'") or error('Could not fetch slug from database.', 500);
if($result === false || mysqli_num_rows($result) == 0) error('Slug not found.', 404);
Expand Down