Skip to content

Fix typo but actually change the whole line #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cyrannosaurus wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix typo but actually change the whole line #20

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adf2af6
Fix typo but actually change the whole line
Cyrannosaurus Nov 7, 2020
2299833
do not imply the dataset is pre-sorted by ip
Cyrannosaurus Nov 7, 2020
20a2b7b
finalize
Cyrannosaurus Nov 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion f20/p5/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,9 @@ Yes, those aren't quite real IP addresses, as explained in the next section...
### 2. `country` Command

This command has two parts: sorting and adding a new country column.
As explained why lateer, the sorting will come first.

Can you think of a reason to sort the countries column before merging?
**Hint** What if the data it is merging with is sorted by the same key?

It's OK if you read in the complete CSV, then sort,
perhaps something like this:
Expand Down