Infer blob lexicon type as BlobRef instead of browser Blob#103
Merged
Conversation
Replaces the browser's `Blob` type with the correct type for Blob references over atproto.
I've defined a local `BlobRef` type (`{ $type, ref, mimeType, size }`) which mirrors the type from `@atproto/api`/`@atproto/lex-data`, without
adding either as a dependency.
tylersayshi
approved these changes
Apr 25, 2026
tylersayshi
left a comment
tylersayshi
left a comment
Owner
There was a problem hiding this comment.
thanks for the fix! this lgtm 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @tylersayshi — I noticed that prototypey uses the browser's
Blobtype for blobs, which means that well-structured records with blobs don't meet the inferred type ({ $type, ref, mimeType, size }doesn't meetBlob).This change replaces
Blobtype with aBlobReftype added (with@seereferences) which mirrors the type from@atproto/api/@atproto/lex-data(and, given how simple it is, I'd imagine elsewhere too).I've called this a breaking change, but I'm not sure that the previous inference would have been useful to anyone.