Skip to content

Commit 52d3aca

Browse files
authored
Add database name validation into connection tests and enhance driver tests (#304)
## Usage and product changes * We add database name validation checks to `connection/database` * We add offset checks for `datetime-tz` in `driver/driver` * We add basic concurrent query result processing tests in `driver/driver` with more explciit todos for the future.
1 parent eb7a792 commit 52d3aca

File tree

2 files changed

+211
-96
lines changed

2 files changed

+211
-96
lines changed

connection/database.feature

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,16 @@ Feature: Connection Database
1111
Given connection is open: true
1212
Given connection has 0 databases
1313

14-
Scenario: create one database
15-
When connection create database: alice
16-
Then connection has database: alice
14+
Scenario Outline: create one database with name <name>
15+
When connection create database: <name>
16+
Then connection has database: <name>
17+
Examples:
18+
| name |
19+
| alice |
20+
| ALICE |
21+
| cAn-be_Like-that_WITH-a_pretty-looooooooooooong_name-and·evena·smile |
22+
| 資料庫 |
23+
1724

1825
Scenario: create many databases
1926
When connection create databases:
@@ -49,15 +56,23 @@ Feature: Connection Database
4956
| eve |
5057
| frank |
5158

59+
Scenario: cannot create database with an incorrect name
60+
Then connection create database with empty name; fails
61+
Then connection create database: .; fails
62+
Then connection create database: !; fails
63+
Then connection create database: ...; fails
64+
Then connection create database: ·‿·; fails
65+
Then connection create database: 😎; fails
66+
Then connection create database: my😎database; fails
67+
5268
Scenario: delete one database
53-
# This step should be rewritten once we can create keypsaces without opening sessions
5469
Given connection create database: alice
5570
When connection delete database: alice
5671
Then connection does not have database: alice
5772
Then connection has 0 databases
5873

5974
Scenario: connection can delete many databases
60-
Given connection create databases:
75+
Given connection create databases:
6176
| alice |
6277
| bob |
6378
| charlie |
@@ -84,7 +99,7 @@ Feature: Connection Database
8499
Then connection has 0 databases
85100

86101
Scenario: delete many databases in parallel
87-
Given connection create databases in parallel:
102+
Given connection create databases in parallel:
88103
| alice |
89104
| bob |
90105
| charlie |

0 commit comments

Comments
 (0)