no_implicit_optional A codemod to make your implicit optional type hints PEP-484 compliant

[cleder]

[sobolevn]

Nice! Thanks!

[orsinium]

We already have auto-optional. I wonder if we should pick one.

[cleder]

Good, point, they seem to do the same thing, auto-optional also has a pre-commit plugin.

[cleder]

Looking through the code and tests, I tend to lean towards auto-optional, but I may be wrong. (Disclaimer I did not test either yet, I don't have code atm where this would be a problem)

[orsinium]

I tried both on a fairly big codebase and no_implicit_optional seemed to fare better. Both tools use libcst under the hood, and in both cases it fails with SyntaxError on some ruff-formatted with statements. However, auto-optional stopped formatting files at the first error while no_implicit_optional skipped formatting only for the failing files and says that it formatted the rest. Plus, no_implicit_optional supports the new union syntax

However, in both cases, I don't see any files actually modified, even if the tool says it did. IDK why. Some kind of dry run? 🤔

[orsinium]

Ah, no, I see, I already fixed implicit optionals in that project, that's why 🙃

[orsinium]

Lets leave both on the list 👍🏿