-
-
Notifications
You must be signed in to change notification settings - Fork 493
Update mypy to 1.17.0 #2744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mypy to 1.17.0 #2744
Conversation
Now that django-stubs targets Python 3.10+, this option serves no purpose. Support for PEP 585 in error messages has been available since mypy v1.4 when using Python 3.9+ and the minimum supported version in django-stubs is now mypy v1.13.
Now that django-stubs targets Python 3.10+, this option serves no purpose. Support for PEP 604 in error messages has been available since mypy v1.4 when using Python 3.10+ and the minimum supported version in django-stubs is now mypy v1.13. Note that there are still some cases where `Union[...]` is used, but these are due to be changed to PEP 604 syntax in mypy v1.17.
Here it is @sobolevn! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet Nick is just a machine ! 💪 👏 👏 |
An evening of forgotten sed commands, recorded macros in vim — blood, sweat, and tears 😅 |
@ngnpope I have an even bigger project to convert, wish me luck 😅 😭 |
@ngnpope btw, maybe you are interested in joining |
I thought we added him already !! |
Invite sent :) |
Good luck! 🍀
Thanks! Yes, am happy to join and keep helping out 😊 |
Mypy version was bumped in django-stubs: * typeddjango/django-stubs#2744 The `force_uppercase_builtins` setting was deprecated in mypy 1.17. Caused test failures due to new logging. https://mypy.readthedocs.io/en/stable/changelog.html#deprecated-flag-force-uppercase-builtins
Mypy version was bumped in django-stubs: * typeddjango/django-stubs#2744 The `force_uppercase_builtins` setting was deprecated in mypy 1.17. Caused test failures due to new logging. https://mypy.readthedocs.io/en/stable/changelog.html#deprecated-flag-force-uppercase-builtins
Mypy version was bumped in django-stubs: * typeddjango/django-stubs#2744 The `force_uppercase_builtins` setting was deprecated in mypy 1.17. Caused test failures due to new logging. https://mypy.readthedocs.io/en/stable/changelog.html#deprecated-flag-force-uppercase-builtins
) Mypy version was bumped in django-stubs: * typeddjango/django-stubs#2744 The `force_uppercase_builtins` setting was deprecated in mypy 1.17. Caused test failures due to new logging. https://mypy.readthedocs.io/en/stable/changelog.html#deprecated-flag-force-uppercase-builtins
Updates mypy to v1.17.0 and removes use of
force_uppercase_builtins
andforce_union_syntax
to align with changes in mypy.Closes #2743