fix: allow to query decimal fields with int #2838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django allow to query decimal fields with int, and given there should be no precision loss, we should accept ints to query such fields. Note: even though we do accept floats when setting a value in a decimal field, I opted for only accepting ints in this PR, as to minimize the impact of the change. Fixes typeddjango#2831.
|
Hey, thanks for the PR! Could you add a small regression test next to this test showcasing correct filter values and ones that should raise error? |
Thanks @UnknownPlatypus, I had written the test but forgot to add it to the PR. Let me know if the test I added is enough. |
sobolevn
reviewed
Sep 24, 2025
Awesome, thanks @sk- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django allow to query decimal fields with int, and given there should be no precision loss, we should accept ints to query such fields.
Note: even though we do accept floats when setting a value in a decimal field, I opted for only accepting ints in this PR, as to minimize the impact of the change.
Related issues
Closes #2831