Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rest_framework.schemas.openapi.ExternalDocumentationObject #704

Closed

Conversation

kwang1215
Copy link

I have made things!

Related issues

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this change is correct. Can you please provide a link to the source code that proves that externalDocs key was removed.

@kwang1215
Copy link
Author

I don't think that this change is correct. Can you please provide a link to the source code that proves that externalDocs key was removed.

I couldn't find the ExternalDocumentationObject class and externalDocs in the rest_framework/schemas/openapi.py file. However, after looking at the commit where ExternalDocumentationObject was first added, I found information related to externalDocs on https://github.com/OAI/OpenAPI-Specification.git.

Is there a connection between rest_framework/schemas/openapi.py and https://github.com/OAI/OpenAPI-Specification.git?
I am still a beginner developer, so I'm not sure.

@kwang1215 kwang1215 requested a review from sobolevn December 9, 2024 11:27
@sobolevn
Copy link
Member

sobolevn commented Dec 9, 2024

Yes, this is a @type_check_only TypedDict object. It represents the OpenAPI JSON spec.

@sobolevn
Copy link
Member

sobolevn commented Dec 9, 2024

I think that it is safe to close this now :)

@sobolevn sobolevn closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants