In zen mode overflowing content should be scrollable#241
Open
In zen mode overflowing content should be scrollable#241
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
linuz90
requested changes
Apr 28, 2025
Dineshs91
force-pushed
the
dinesh/04-16-in_zen_mode_overflowing_content_should_be_scrollable
branch
from
a1900dc to
0399e8d
Compare
Contributor
Author
Dineshs91
changed the base branch from
dinesh/04-16-don_t_open_welcome_page_on_extension_update
to
graphite-base/241
Dineshs91
force-pushed
the
dinesh/04-16-in_zen_mode_overflowing_content_should_be_scrollable
branch
from
0399e8d to
f805b96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Changed the body overflow property from
hiddentoscrollin writer mode.What changed?
Modified the CSS in the
changeWriterModefunction to set the body's overflow property toscrollinstead ofhidden.How to test?
Why make this change?
The previous
overflow: hiddensetting prevented users from scrolling through content that exceeded the viewport height in writer mode. This change ensures users can access all content while maintaining the clean writer mode interface.Fix MIN-31 and #169
CleanShot 2025-04-16 at 22.34.55.mp4 (uploaded via Graphite)