OpenTelemetry module should record canceled spans as errors #1203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpholt
force-pushed
the
otel-canceled-span-status
branch
from
79eeeb0 to
a12d4ee
Compare
bpholt
force-pushed
the
otel-canceled-span-status
branch
from
a12d4ee to
d75f9db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's misleading to record canceled spans using
StatusCode.UNSET. The spec saysbut a canceled span did not successfully complete. There's no canceled status in the spec, so I think
StatusCode.ERRORis the more appropriate choice.This came up as I was looking at some trace data this afternoon and initially thought a bunch of parallel operations succeeded, with only one failure. Only after more investigation did I realize that the failure actually resulted in the other operations being canceled; none of them actually completed successfully. This would have been immediately obvious if the canceled operations had the Error status set.