Contributing back all current updates of my fork #933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix/tests
Update/dependencies
update/linter: packages updated. new config files.
* some automatic linter fixes. Some typescript fixes. * typescript errors fixed in decorators and metadata * Interceptors and Metadata fixed * reverted filterMiddlewareMetadatasForClasses * decorator, driver and metadata types fixed * interceptor and metadata fixed * action, driver and metadata fixed
* update/github-workflows * prettier, linter and build errors fixed
* updated typedi,mustache-express,@types/node and some smaller updates * axios updated to last cjs version * updated husky,form-data,lint-staged * jest updated. done callback fixed. TypeScript errors fixed in test folder. * prettier fixes. nodejs workflow matrix adjusted. * eslint, jest updated. request removed. * koa and dependencies updated * updated multer to 1.4.4 and koa types * axios upgraded and fixed boolean header. jest wrong error line number fixed.
|
Thanks! Unfortunately i find this a bit drastic so i cherrypicked the upgrades into a separate PR. I will make sure to credit you in the changelog! |
|
Thanks, glad it helps a little bit. I had the same thoughts about cherry picking. I just did not want to withhold anything. |
|
Changes merged in #948 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributing all current updates of my fork as requested here.
I reverted some changes like the README, the name and version in the package.json and the GitHub workflows, except NodeJS 12 is dropped now. Most of the TypeScript warnings are not fixed yet but the erros are gone.
Checklist
Update index.md)develop)npm run prettier:checkpassesnpm run lint:checkpassesFixes