Version tracker, tracing enhancements and ui changes #26

tysonthomas9 · 2025-07-20T06:46:10Z

Version tracker
Tracing enhancements
UI changes
Tool tests

tysonthomas9 · 2025-07-21T04:54:23Z

front_end/panels/ai_chat/core/Version.ts

+// found in the LICENSE file.
+
+export const VERSION_INFO = {
+  version: '0.1.5',


Copilot

Pull Request Overview

This PR adds comprehensive version tracking, enhanced tracing capabilities, and UI improvements to the AI Chat panel. Key additions include automated version checking with update notifications, hierarchical distributed tracing for better observability, and improved user interface elements with accessibility testing infrastructure.

Version tracking system with automated update notifications and GitHub release integration
Enhanced hierarchical tracing with improved agent execution observability
UI improvements including better model selection, updated styling, and agent session visualization
Comprehensive accessibility testing infrastructure with e2e test resources

Reviewed Changes

Copilot reviewed 44 out of 44 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
test/e2e_non_hosted/ai_chat/accessibility-tree-integration_test.ts	New e2e test for accessibility tree integration testing
test/e2e_non_hosted/ai_chat/BUILD.gn	Build configuration for ai_chat e2e tests
test/e2e/resources/ai_chat/*.html	Test HTML resources for accessibility testing scenarios
front_end/ui/components/markdown_view/markdownView.css	Minor font size adjustment for better readability
front_end/panels/ai_chat/ui/chatView.css	Extensive UI styling updates including model selector, version banner, and agent timeline styles
front_end/panels/ai_chat/ui/ChatView.ts	Major UI enhancements with version checking, searchable model selector, and agent session rendering
front_end/panels/ai_chat/tracing/*.ts	Enhanced tracing system with hierarchical observation support
front_end/panels/ai_chat/tools/*.ts	Removal of duplicate tracing code from individual tools
front_end/panels/ai_chat/core/*.ts	Version tracking system and enhanced agent execution with tracing

Comments suppressed due to low confidence (3)

front_end/panels/ai_chat/ui/ChatView.ts:16

[nitpick] The import alias 'AgentToolCallMessage' and 'AgentToolResultMessage' are verbose. Consider shorter, clearer aliases like 'AgentToolCall' and 'AgentToolResult'.

import type { AgentSession, AgentMessage, ToolCallMessage as AgentToolCallMessage, ToolResultMessage as AgentToolResultMessage } from '../agent_framework/AgentSessionTypes.js';

front_end/panels/ai_chat/ui/ChatView.ts:294

[nitpick] The field name '#isVersionBannerDismissed' uses a double negative. Consider renaming to '#showVersionBanner' for clearer logic.

  #isVersionBannerDismissed = false;

Copilot · 2025-07-25T06:38:25Z

front_end/panels/ai_chat/ui/ChatView.ts

+    if (!this.#versionInfo || !this.#versionInfo.isUpdateAvailable || 
+        this.#isVersionBannerDismissed || this.#messages.length > 1) {


Complex conditional logic for version banner visibility. Consider extracting to a private method like '#shouldShowVersionBanner()' to improve readability.

Suggested change

if (!this.#versionInfo || !this.#versionInfo.isUpdateAvailable ||

this.#isVersionBannerDismissed || this.#messages.length > 1) {

if (!this.#shouldShowVersionBanner()) {

Copilot · 2025-07-25T06:38:26Z

front_end/panels/ai_chat/tracing/LangfuseProvider.ts

-  private readonly flushInterval = 1000; // 5 seconds
+  private readonly batchSize = 20; // Reasonable batch size for hierarchical tracing
+  private readonly flushInterval = 5000; // 5 seconds - less frequent auto-flush
+  private readonly maxBufferSize = 1000; // Prevent memory exhaustion


[nitpick] Buffer size of 1000 events may be excessive for typical usage. Consider making this configurable or reducing to a more reasonable default like 500.

Suggested change

private readonly maxBufferSize = 1000; // Prevent memory exhaustion

private readonly maxBufferSize: number; // Prevent memory exhaustion

Copilot · 2025-07-25T06:38:26Z

front_end/panels/ai_chat/tracing/LangfuseProvider.ts

+    for (const [key, value] of Object.entries(data)) {
+      // Skip problematic keys that often cause circular references
+      if (key === 'agentSession' && value && typeof value === 'object') {
+        // Keep only essential agentSession data
+        sanitized[key] = {
+          sessionId: (value as any).sessionId,
+          agentName: (value as any).agentName,
+          status: (value as any).status,
+          messageCount: (value as any).messages?.length || 0,
+          startTime: (value as any).startTime,
+          endTime: (value as any).endTime
+        };


Hard-coded special handling for 'agentSession' key makes the sanitization logic brittle. Consider using a configuration object or separate sanitization strategies for different data types.

Suggested change

for (const [key, value] of Object.entries(data)) {

// Skip problematic keys that often cause circular references

if (key === 'agentSession' && value && typeof value === 'object') {

// Keep only essential agentSession data

sanitized[key] = {

sessionId: (value as any).sessionId,

agentName: (value as any).agentName,

status: (value as any).status,

messageCount: (value as any).messages?.length || 0,

startTime: (value as any).startTime,

endTime: (value as any).endTime

};

const sanitizationStrategies: Record<string, (value: any) => any> = {

agentSession: (value: any) => ({

sessionId: value.sessionId,

agentName: value.agentName,

status: value.status,

messageCount: value.messages?.length || 0,

startTime: value.startTime,

endTime: value.endTime,

}),

};

for (const [key, value] of Object.entries(data)) {

// Apply key-specific sanitization strategies if defined

if (sanitizationStrategies[key] && value && typeof value === 'object') {

sanitized[key] = sanitizationStrategies[key](value);

Copilot · 2025-07-25T06:38:26Z

front_end/panels/ai_chat/core/VersionChecker.ts

+
+export class VersionChecker {
+  private static instance: VersionChecker;
+  private readonly GITHUB_API_URL = 'https://api.github.com/repos/tysonthomas9/browser-operator-devtools-frontend/releases/latest';


Hard-coded GitHub repository URL should be configurable or extracted to a configuration file to support different deployments.

Copilot · 2025-07-25T06:38:26Z

front_end/panels/ai_chat/core/VersionChecker.ts

+
+      logger.info('Latest version from GitHub:', { tag: releaseData.tag_name, extracted: latestVersion });
+
+      const comparison = this.compareVersions(this.currentVersion, latestVersion);


Version comparison may fail for non-semantic versions or versions with different formats. Consider using a more robust version comparison library or adding format validation.

Copilot · 2025-07-25T06:38:26Z

test/e2e_non_hosted/ai_chat/accessibility-tree-integration_test.ts

+        // @ts-ignore DevTools context
+        const utilsModule = window.Root?.Runtime?.cachedResources?.get?.('/front_end/panels/ai_chat/common/utils.js');
+        if (!utilsModule?.getAccessibilityTree) {
+          // Fallback: try dynamic import
+          // @ts-ignore DevTools context
+          const module = await import('/front_end/panels/ai_chat/common/utils.js');
+          if (module?.getAccessibilityTree) {
+            // @ts-ignore DevTools context
+            const SDKModule = await import('/front_end/core/sdk/sdk.js');


Multiple @ts-ignore comments indicate type safety issues. Consider defining proper TypeScript interfaces for the DevTools context objects being accessed.

Suggested change

// @ts-ignore DevTools context

const utilsModule = window.Root?.Runtime?.cachedResources?.get?.('/front_end/panels/ai_chat/common/utils.js');

if (!utilsModule?.getAccessibilityTree) {

// Fallback: try dynamic import

// @ts-ignore DevTools context

const module = await import('/front_end/panels/ai_chat/common/utils.js');

if (module?.getAccessibilityTree) {

// @ts-ignore DevTools context

const SDKModule = await import('/front_end/core/sdk/sdk.js');

const utilsModule = (window.Root?.Runtime?.cachedResources?.get?.('/front_end/panels/ai_chat/common/utils.js') as UtilsModule | undefined);

if (!utilsModule?.getAccessibilityTree) {

// Fallback: try dynamic import

const module = (await import('/front_end/panels/ai_chat/common/utils.js')) as UtilsModule;

if (module?.getAccessibilityTree) {

const SDKModule = (await import('/front_end/core/sdk/sdk.js')) as SDKModule;

version tracker, tracing enhancements and ui changes

42d2fce

tysonthomas9 requested a review from Copilot July 20, 2025 06:46

This comment was marked as outdated.

Sign in to view

tysonthomas9 commented Jul 21, 2025

View reviewed changes

tysonthomas9 added 2 commits July 24, 2025 23:29

Merge branch main into feature/ui-tracing-enhancements

2bcbc8f

fix removed config files

03118c3

tysonthomas9 requested review from Copilot and olesho July 25, 2025 06:36

Copilot AI reviewed Jul 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Version tracker, tracing enhancements and ui changes #26

Version tracker, tracing enhancements and ui changes #26

Uh oh!

tysonthomas9 commented Jul 20, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

tysonthomas9 Jul 21, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 25, 2025

Uh oh!

Copilot AI Jul 25, 2025

Uh oh!

Copilot AI Jul 25, 2025

Uh oh!

Copilot AI Jul 25, 2025

Uh oh!

Copilot AI Jul 25, 2025

Uh oh!

Copilot AI Jul 25, 2025

Uh oh!

Uh oh!

		if (!this.#versionInfo \|\| !this.#versionInfo.isUpdateAvailable \|\|
		this.#isVersionBannerDismissed \|\| this.#messages.length > 1) {

	if (!this.#versionInfo \|\| !this.#versionInfo.isUpdateAvailable \|\|
	this.#isVersionBannerDismissed \|\| this.#messages.length > 1) {
	if (!this.#shouldShowVersionBanner()) {

	private readonly maxBufferSize = 1000; // Prevent memory exhaustion
	private readonly maxBufferSize: number; // Prevent memory exhaustion


		logger.info('Latest version from GitHub:', { tag: releaseData.tag_name, extracted: latestVersion });

		const comparison = this.compareVersions(this.currentVersion, latestVersion);

Version tracker, tracing enhancements and ui changes #26

Are you sure you want to change the base?

Version tracker, tracing enhancements and ui changes #26

Uh oh!

Conversation

tysonthomas9 commented Jul 20, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

tysonthomas9 Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!