Bump ruby 3.3 #3697
Open
Bump ruby 3.3 #3697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgwillia
requested review from
ConnorSheremeta,
jefferya and
lagoan
as code owners
pgwillia
force-pushed
the
bump_ruby_3.4
branch
from
380556b to
ca59d73
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ConnorSheremeta
requested changes
Feb 21, 2025
|
My apologies for jumping the gun, I had mistaken this with another PR in the dev-pull-request channel and realise now that this might not be ready for review. |
I thought this was ready too, but library-cms is a higher priority so we'll do that first. I appreciate any feedback you have! |
csv was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0. You can add csv to your Gemfile or gemspec to silence this warning.
ostruct.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
More easily available in RHEL/centos ecosystem. Can revisit 3.4 when it's more mature.
pgwillia
force-pushed
the
bump_ruby_3.4
branch
from
c7196d5 to
8fedf6d
Compare
Layout/LineLength: Line is too long. [153/120] (https://rubystyle.guide#max-line-length)
pgwillia
force-pushed
the
bump_ruby_3.4
branch
from
8fedf6d to
ec402c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This morning breakman warned us that
Related to https://github.com/ualbertalib/library_applications_development/issues/163
What's New
Bump Ruby to 3.3 in Gemfile, working dev environment, and part of CI strategy (include 3.4 as well).
Not done: docker environment