Predicate the call to trace_mem() #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pin sampler inserts a call to trace_mem() and a predicated
call to trace_update_access_counter() that is NOT called if the current instruction is a predicate (cmov, ...)
and the condition is false.
This could lead to the situation where the access counter is not updated but the memory access is recorded by the sampler, and
thus to the situation where two samples accessing the same memory location have the same timestamp.
This causes the current model to exit with this error:
File "/home/moncef/coding/uart/util/python/util/analysis_orig/utils.py", line 50, in usf_read_events
assert(event.begin.time < event.end.time)
AssertionError
This patch makes the call to trace_mem() predicated too so that if the current instruction is a predicate and the condition is false,
the memory access is not passed to the sampler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pin sampler inserts a call to trace_mem() and a predicated
call to trace_update_access_counter() that is NOT called if the current instruction is a predicate (cmov, ...)
and the condition is false.
This could lead to the situation where the access counter is not updated but the memory access is recorded by the sampler, and
thus to the situation where two samples accessing the same memory location have the same timestamp.
This causes the current model to exit with this error:
File "/home/moncef/coding/uart/util/python/util/analysis_orig/utils.py", line 50, in usf_read_events
assert(event.begin.time < event.end.time)
AssertionError
This patch makes the call to trace_mem() predicated too so that if the current instruction is a predicate and the condition is false,
the memory access is not passed to the sampler