Added C90 complexity checks with ruff. #767
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e above complexity were noqa'd and given FIXME tags to come back to at a later date. Signed-off-by: Eric Butcher <[email protected]>
Eric-Butcher
force-pushed
the
feature/ruff-c90
branch
from
31ed2eb to
7765425
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions and methods that were above complexity were noqa'd and given FIXME tags to come back to at a later date.
This will not help fix any current problems with maintainability in the code base but will prevent future ones.
This check looks for any functions or methods that have a McCabe Complexity / Cyclomatic Complexity higher than 10.
At some point it would be nice if ColdFront as a project could push this number down a bit further but ten is a good starting point.