Add support for slurm parent accounts. #782
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cecilia Lau <[email protected]>
Signed-off-by: Cecilia Lau <[email protected]>
Signed-off-by: Cecilia Lau <[email protected]>
…update readme Signed-off-by: Cecilia Lau <[email protected]>
Signed-off-by: Cecilia Lau <[email protected]>
cecilialau6776
force-pushed
the
slurm_parents
branch
from
e44f69b to
af1cee8
Compare
|
@cecilialau6776 Thanks for the PR. Can you confirm this doesn't change the existing behavior in any way. i.e. this only adds functionality? Also, can you squash into single commit. Thanks! |
|
I'm just about certain that this doesn't change existing functionality in any way, but would feel more comfortable with another set of eyes or two to check that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Slurm allocations to have parents/children.
associations.pyslurm_childrenallocation attributeI could also add an admin-only notification for invalid
slurm_children(i.e. when aslurm_childrenaccount doesn't exist)Closes #746.