fix issue 793: Sum of char field #794
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@csbarnet Same with this one, squash into single signed commit |
added simple test to show that center-summary renders Signed-off-by: Chris Barnett <[email protected]>
csbarnet
force-pushed
the
bug-fix-grant-sum-summary
branch
from
fd9703b to
250a1f0
Compare
|
@aebruno squashed and signed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix for issue 793
In this PR, in coldfront.core.portal.views center_summary, the "total_amount_awarded" field is cast from CharField to FloatField before Sum is applied.
As there was no current test for the portal module, added a simple test that shows a user can retrieve the page and that section headers appear on the page.