remove unnecessary connection in project_openldap utils.py #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonLeary42
reviewed
Oct 9, 2025
|
|
||
| try: | ||
| conn.modify(dn, {"description": [(MODIFY_REPLACE, [openldap_description])]}) | ||
| conn.unbind() |
Contributor
There was a problem hiding this comment.
this line should also be removed
Contributor
Author
There was a problem hiding this comment.
yes overzealous use of unbind... will correct in due course
Contributor
Author
There was a problem hiding this comment.
corrected now in latest force push
simonLeary42
reviewed
Oct 9, 2025
|
|
||
| try: | ||
| conn.modify_dn(current_dn, relative_dn, new_superior=archive_ou) | ||
| conn.unbind() |
Contributor
Author
There was a problem hiding this comment.
yes overzealous use of unbind... will correct in due course
Contributor
Author
There was a problem hiding this comment.
corrected now in latest force push
ds-04
force-pushed
the
project_openldap_fix_connection_i
branch
from
ceba62b to
738b5ef
Compare
Signed-off-by: David Simpson <>
ds-04
force-pushed
the
project_openldap_fix_connection_i
branch
from
738b5ef to
34edfd3
Compare
aebruno
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Simpson <>
remove unnecessary connection in project_openldap utils.py