Fix TQDM_DISABLE=1 compatibility issue with cmdstanpy #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add cmdstanpy_compat.py with patch_tqdm_progress_hook() function - Patch cmdstanpy progress hooks to safely handle disabled tqdm objects - Apply patch in stan_estimator.py when TQDM_DISABLE=1 is set - Add comprehensive test suite covering all scenarios Fixes uber#887
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes AttributeError when TQDM_DISABLE=1 is set before importing orbit. The issue occurs because cmdstanpy assumes tqdm progress bars have a 'postfix' attribute, but disabled tqdm objects don't have this attribute.
Changes
orbit/utils/cmdstanpy_compat.pywith safe progress hook implementationorbit/estimators/stan_estimator.pywhen TQDM_DISABLE=1Test Plan
Closes #887