Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to .NET 8 #318

Closed
wants to merge 0 commits into from
Closed

Move to .NET 8 #318

wants to merge 0 commits into from

Conversation

cmello
Copy link
Contributor

@cmello cmello commented Dec 5, 2023

Hi,

If you would be interested in moving to .NET 8, this PR might be helpful.

Thanks!

Best regards,
Cesar

@baudronp
Copy link
Collaborator

baudronp commented Dec 5, 2023

Thanks @cmello for the PR!

We are also planning to move to net8, but there is deployment consideration that we need to tackle first 🙂

We may also considere multitargetting to net6 and net8 to let other external devs plan there migration at there own pace.

Anyway we will take a look a your PR, and maybe not take it exactly as is/redo it (don't take it personnally if we do 😅).

@cmello
Copy link
Contributor Author

cmello commented Dec 5, 2023

Thank you for the kind words @baudronp . :-) No rush, I was just taking a look at the amount of work it would take to upgrade to .NET 8, and shared the experiment as it could be helpful when migrating to .NET 8 for real. Thanks!

@jspelletier
Copy link
Collaborator

Hello Cesar,
You are interested into targetting .net 8 in the generated csproj or running sharpmake under .net 8? These are two totally different things. I see you did both. Targetting .net 8 in the generated csproj is a trivial change that could and should be submitted separately from an update of sharpmake for .net 8.

@cmello
Copy link
Contributor Author

cmello commented Dec 6, 2023

Hi Jean, I am interested in both. But neither is urgent. I can submit the csproj generation one separately if it looks correct. Thanks for your attention!

@jspelletier
Copy link
Collaborator

please create a PR for the csproj .net8 generation.

@cmello
Copy link
Contributor Author

cmello commented Dec 7, 2023

PR for csproj .NET 8 generation: #319

Thanks!

@cmello
Copy link
Contributor Author

cmello commented Jan 15, 2024

Unintentionally removed the PR contents while cleaning up my fork branches. The code corresponding to this PR is available in branch https://github.com/cmello/Sharpmake/tree/upgrade_to_net8 , but I am not moving forward with it for now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants