Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improve Manual Decimal Input Precision and Use SingleActivator #99

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

saulrmzlpz
Copy link

@saulrmzlpz saulrmzlpz commented Mar 21, 2025

Justification

After performing some tests on manual quantity entry, I noticed that allowing decimal input becomes difficult when precision exceeds two decimal places. For example, trying to enter “0.935” using the keyboard causes the field to auto-complete with “0.900” as soon as “0.9” is typed, making manual entry challenging.

Additionally, TODO changes were implemented to use SingleActivator.

Note: Based on these changes, some tests were commented out and need to be reviewed.

Changes:
Bump version to 0.13.2
Update SpinBox with improved decimal formatting
Use SingleActivator for keyboard shortcuts

@Feichtmeier Feichtmeier requested a review from jpnurmi March 21, 2025 16:10
@jpnurmi
Copy link
Collaborator

jpnurmi commented Mar 24, 2025

Hi, my apologies that this package hasn't been actively maintained for a while. Could we start with the SDK updates, formatting changes, refactoring etc. in separate PRs to avoid mixing them up with the actual fix, please?

@saulrmzlpz
Copy link
Author

Hi, my apologies that this package hasn't been actively maintained for a while. Could we start with the SDK updates, formatting changes, refactoring etc. in separate PRs to avoid mixing them up with the actual fix, please?

Of course, let me check the changes and send you the PRs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants