feat: add gnome style type to search #1164
Conversation
|
@IldySilva thanks for your PR! For some reason this PR sometimes vanished then came back, did you do some magic? 😄 🪄 you need to resolve the conflicts then we can get it in! |
Feichtmeier
changed the title
|
abracadrabra @Feichtmeier 😄 🪄 github flagged my account for about 2 Months,so my profile and contributions just vanished |
Wow how did this happen? |
|
they flagged my account as spammy after notice some suspect activity (was just me deleting an old repo) |
|
@Feichtmeier pls review |
|
@IldySilva sorry I'll review it soon One thing I already noticed was the wild focus node somewhere in a model. A focusnode only belongs in the widget tree |
| @@ -308,4 +309,10 @@ class LibraryModel extends SafeChangeNotifier implements NavigatorObserver { | |||
| final GlobalKey<NavigatorState> _masterNavigatorKey = | |||
| GlobalKey<NavigatorState>(); | |||
| GlobalKey<NavigatorState> get masterNavigatorKey => _masterNavigatorKey; | |||
|
|
|||
| AudioType getCurrentAudioType() => switch (selectedPageId) { | |||
There was a problem hiding this comment.
this sadly doesnt always work, as starred stations and subbed podcasts also are put into the sidebar and can be selected :(
There was a problem hiding this comment.
but you could add a function which uses something like isPageInLibrary like checking playlists, podcasts, starredStations, pinnedAlbums and the main page ids
| @@ -58,6 +61,37 @@ class _DesktopHomePageState extends State<DesktopHomePage> { | |||
| }); | |||
| } | |||
|
|
|||
| void _onTypeHandler(KeyEvent event) { | |||
| if (!AppConfig.isGtkApp || event.logicalKey == LogicalKeyboardKey.control) { | |||
There was a problem hiding this comment.
can you please also check for mac os (CMD) and windows (control)
Closes #1142