Build Runtime and test it - #344
Conversation
00b4886 to
86e9ba3
Compare
|
Is this good to go now? A part squashing the last commit with the initial one, I feel that we're good here. |
|
I still want to add the tests themselves: to install several snaps, launch them, and ensure that they run instead of failing. |
Fair.. Well, can we just add some very dummy test for now (just ensure that some simple app starts and closes without failing)? So we can unblock #294 or can we land that without this? |
67b023a to
a3e0ccc
Compare
7cd3915 to
1ab5797
Compare
|
@3v1n0 I squashed all the commits, and it's ready for review. |
1ab5797 to
e843ad7
Compare
3v1n0
left a comment
3v1n0
left a comment
There was a problem hiding this comment.
Thanks for this and lots of tests.
There are some things to re-enable, but first I've some cleanups to suggest.
Also, checking the logs, maybe it's also worth to install the xdg-desktop-portal (gtk or gnome)? As they are used by some snaps and in general it's a requirement component to get the snaps working
|
Maybe temporarily revert 09aca1c :) |
397004a to
9bb389a
Compare
9f400a7 to
0321125
Compare
|
@3v1n0 mattermost was updated this last friday, and now it doesn't launch. It returns a GPU problem. Any idea? |
|
I would still like to launch a proper dbus session, or even the whole |
I tried over and over, but it fails due to a cgroups problem. |
In fact, I'm already configuring the DBUS environment variable to point to the already-running dbus-session instance, and both dconf-daemon and xdg-desktop-portal binaries are being automatically launched, so that error must be due to a different reason. |
340ba7e to
910175d
Compare
|
The problem with mattermost is in mattermost itself, so we have to wait for a new version. |
Could be because the gtk portal does not implement it? Should we try the gnome one? |
|
I restored all the flags. |
|
@3v1n0 Maybe the problem with Evince is this? |
636dd8d to
f5eb933
Compare
|
@3v1n0 Ok, I restored everything. When mattermost is fixed, I think that we can merge this. |
|
@3v1n0 Ok, all tests are passing!!!!! The only open conversation is the name for the YARF logs files. |
3v1n0
left a comment
3v1n0
left a comment
There was a problem hiding this comment.
See that comment if it makes sense, otherwise LGTM.
Also see if some commits (refactoring previous ones) can be squashed.
|
@aleasto Not sure what uses right now dbus-launch... let's test it. |
8edb6c3 to
f7c2018
Compare
This PR builds the runtime agains a new SDK, and tests it against several snaps. Specifically, it tests: * firefox * epiphany * thunderbird * darktable * cheese * gimp * gnome-calculator * gnome-system-monitor * gnome-text-editor * evince * kicad * chromium * shotwell * telegram * mattermost It uses YARF OCR capabilities to detect that the application has been launched correctly. After it detects it, it waits five seconds and test again, to ensure that it is still working (thus to avoid the case where the window does appear but the application crashes immediately). If a test fails, it uploads an artifact with the YARF logs, to check if it's a test problem or a PR problem.
f7c2018 to
27f1ed9
Compare
|
OK, I removed dbus-launch, and it works fine, so... It should be ready. |
3v1n0
left a comment
3v1n0
left a comment
There was a problem hiding this comment.
Nice thanks a lot for working on this, it will be very relevant and helpful I think (especially when the CI will fail and we have to debug it 😂)!
3 participants
This PR builds the runtime against a new SDK, and tests it against several snaps. Specifically, it tests:
It uses YARF OCR capabilities to detect that the application has been launched correctly. After it detects it, it waits five seconds and test again, to ensure that it is still working (thus to avoid the case where the window does appear but the application crashes immediately).
If a test fails, it uploads an artifact with the YARF logs, to check if it's a test problem or a PR problem.