Skip to content

Fix SIGSEGV crash in _getActivationToken when appInfo is null #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doziedotdev wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix SIGSEGV crash in _getActivationToken when appInfo is null #607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68156d9
fix(appIndicator): prevent null appName in _getActivationToken
doziedotdev Jan 2, 2026
90f29a0
fix(appIndicator): add null guard for fakeAppInfo
doziedotdev Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion appIndicator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,9 +763,16 @@ export class AppIndicator extends Signals.EventEmitter {

_getActivationToken(timestamp) {
const launchContext = global.create_app_launch_context(timestamp, -1);
// Ensure appName is never null to prevent crash in g_app_info_get_name()
const appName = this.id || this._commandLine || 'unknown';
const fakeAppInfo = Gio.AppInfo.create_from_commandline(
this._commandLine || 'true', this.id,
this._commandLine || 'true', appName,
Gio.AppInfoCreateFlags.SUPPORTS_STARTUP_NOTIFICATION);

// Guard against null fakeAppInfo to prevent SIGSEGV in get_startup_notify_id()
if (!fakeAppInfo)
return [launchContext, null];

return [launchContext, launchContext.get_startup_notify_id(fakeAppInfo, [])];
}

Expand Down