feat!: Update font to Ubuntu Sans - #1063
Conversation
|
@juanruitina can you confirm this looks correct? I believe the new font has some slightly thicker weight. |
59ba366 to
c082711
Compare
|
Thank you for all this. Can we move the variable fonts perhaps to a togglable container (perhaps |
b5799fa to
05dc920
Compare
|
Since this change is very minor but breaking because of the Flutter upgrade, I think we should consider postponing this for Yaru 11+, especially since Flutter 3.41 is so new. |
alright! |
|
Hi @ashuntu @Feichtmeier do I close my pr #996 in favour of this? |
I think this PR has the benefit of utilizing the 3.41 features to apply font weights, however, this obviously requires Flutter 3.41. I don't necessarily think this is conflicts directly with #996, as we could technically merge #996 if the CI passed and then merge this PR later for the 3.41 weight features. I also haven't tested #996 to see how it interacts with custom weights in code. Ultimately, this is up to @Feichtmeier and others. |
sure sounds like a plan, align yaru with 3.41 (but is it stable enough on linux? I became quite conservative with flutter versions in the last year and am rocking 3.38.10 pretty solid on all operating systems) and then merge this here |
Yeah, I think that's why we should keep this as draft for a while, most likely until our Ubuntu apps are up to date which probably won't be for a little while due to previous instability with Flutter upgrades. |
Also increase titleSmall weight
This allows us to use TextWeight for variable fonts. The test dependency doesn't seem necessary, as flutter_test provides the same functionality. It also introduces problems upgrading Flutter.
05dc920 to
2e98543
Compare
|
We also need emoji fallback fonts, please @ashuntu if you keep working on this PR again, let's fix emojis and chinese fonts on ARM with this branch here, they are bugged like hell with yaru.dart |
Updates the default font from Ubuntu to Ubuntu Sans and Ubuntu Mono to Ubuntu Sans Mono.
This uses the variable fonts from https://github.com/canonical/Ubuntu-Sans-fonts/tree/main/fonts/variable and https://github.com/canonical/Ubuntu-Sans-Mono-fonts/tree/main/fonts/variable.
This requires >=Flutter 3.41 to support
FontWeightfor variable fonts.I've also added some toggles/sliders to the font page so you can view different variations of the fonts. Leaving weight and width unchecked will use the default weight and width of the given text style.
cc @juanruitina
UDENG-9088