Skip to content

feat(YaruWindowControl): follow system settings - #966

Draft
Feichtmeier wants to merge 14 commits into
mainfrom
Feichtmeier/issue532
Draft

feat(YaruWindowControl): follow system settings#966
Feichtmeier wants to merge 14 commits into
mainfrom
Feichtmeier/issue532

Conversation

@Feichtmeier

@Feichtmeier Feichtmeier commented Nov 30, 2024

Copy link
Copy Markdown
Member
Bildschirmaufzeichnung.vom.2024-12-20.00-12-24.mp4

Fixes #532

@Feichtmeier
Feichtmeier force-pushed the Feichtmeier/issue532 branch 2 times, most recently from f6619f5 to e77ac04 Compare November 30, 2024 14:06
@Feichtmeier
Feichtmeier marked this pull request as ready for review December 19, 2024 23:09
@Feichtmeier
Feichtmeier requested a review from Jupi007 December 19, 2024 23:09
@Feichtmeier

Copy link
Copy Markdown
Member Author

@Jupi007 now it works, please have a look :)

@Jupi007

Jupi007 commented Dec 20, 2024

Copy link
Copy Markdown
Member

Sorry @Feichtmeier I will test this only this night. I need to upgrade flutter with my sh*t internet connexion...
But it looks awesome, nice job!

@Jupi007

Jupi007 commented Dec 20, 2024

Copy link
Copy Markdown
Member

I think this row shouldn't be displayed while being empty, because it push the title to the right which looks weird:

image

@Feichtmeier

Copy link
Copy Markdown
Member Author

also found an issue with single titlebars! Back to draft you punky PR!!!

@Feichtmeier
Feichtmeier marked this pull request as draft December 20, 2024 23:46
@Feichtmeier

Copy link
Copy Markdown
Member Author

@ashuntu could you eventually try to resolve the conflicts because I don't know what your changes where and I might make a mistake, if not, I try to schedule more time for this PR and resolve it myself

@ashuntu

ashuntu commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

@ashuntu could you eventually try to resolve the conflicts because I don't know what your changes where and I might make a mistake, if not, I try to schedule more time for this PR and resolve it myself

I believe the only changes I made to these files are the semantic labels for the window buttons. I can look at doing this after other work if you don't get to it before me.

@ashuntu

ashuntu commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

@Feichtmeier I think I've resolved the merge conflict, let me know if I missed anything

@Feichtmeier

Copy link
Copy Markdown
Member Author

@Feichtmeier I think I've resolved the merge conflict, let me know if I missed anything

Thank you very much!
I hope I can finish this soon on an ubuntu machine! its kinda highly requested but a bit tricky

@Feichtmeier

Copy link
Copy Markdown
Member Author

@ashuntu @d-loose I don't have the time to finish this

Most things were working back then it just needs a merge from main and polish

Since this is a highly requested feature by Ubuntu desktop users, could anyone of you please bring it to an end? 🙏 Thank you and best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Window title bar: follow system settings

3 participants