Skip to content

Conversation

@yiakwy-xpu-ml-framework-team
Copy link

@yiakwy-xpu-ml-framework-team yiakwy-xpu-ml-framework-team commented Nov 7, 2025

Description

Please include a summary of the changes and the related issue.

Add build scripts insider docker .

For some reasons, we our system is managed with official NVIDIA software management tools to configure images cross clusters.

Hence for quick test , we just build software inside docker.

OS : ubuntu 22.04
CUDA SDK : 12.8

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Build system

How Has This Been Tested?

Include any tests here.

  • Unit tests
  • Integration tests
  • Manual testing

Checklist

  • My code follows the style guidelines, e.g. format.sh.
  • I have run build_and_install.sh to verify compilation.
  • I have removed redundant variables and comments.
  • I have updated the documentation.
  • I have added tests.

build_and_install.sh

截屏2025-11-07 23 50 18

@yiakwy-xpu-ml-framework-team
Copy link
Author

yiakwy-xpu-ml-framework-team commented Nov 7, 2025

Hi @YangZhou1997 @derekwin could you have a look at it ?

@yiakwy-xpu-ml-framework-team yiakwy-xpu-ml-framework-team marked this pull request as draft November 7, 2025 15:43
@yiakwy-xpu-ml-framework-team yiakwy-xpu-ml-framework-team marked this pull request as ready for review November 7, 2025 15:51
@derekwin
Copy link
Collaborator

LGTM! Thank you very much!

@derekwin
Copy link
Collaborator

@YangZhou1997 I have one question: Would it be advisable to include a .pre-commit-config.yaml file to ensure safe local validation before commits?

@YangZhou1997
Copy link
Member

YangZhou1997 commented Nov 19, 2025

Thanks @yiakwy-xpu-ml-framework-team for the PR, and @derekwin for reviewing.

I am less familiar with the pre-commit check. Let me @MaoZiming to see how you think of the current pre-commit config.

@yiakwy-xpu-ml-framework-team, re the build inside docker, I am thinking of making the build functions reusable such as build_rdma() etc. Maybe try to extract them out into a separate bash file called build_func.sh, and source this file in build.sh and build_insider_docker.sh?

Re the unnecessary libdrm-dev libdrm-amdgpu1 dependencies, it would be great if you could remove them for all docker files we have.

@yiakwy-xpu-ml-framework-team
Copy link
Author

@YangZhou1997 Sure. Once it is ready I can rebase on it the last branch.

With more and more codes, I surelly need an automatic code cleaner to unify the styles. This is standard file we use in SGlang and vLLM.

I am working on ep benchmark to better understand our design! Hope I can contribute to core funcion soon.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants