Merged
Conversation
Takes `bin/bench_dwt` from 1.618 s to 0.432 s on my system.
Contributor
Author
|
For this one, I also verified that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes
bin/bench_dwtfrom 1.618 s to 0.432 s on my system.Sadly, despite being a much bigger win in
bench_dwttime, it's a much smaller end-to-end time improvement than #1629, as time spent in idwt is smaller than time spent in T1 / MQC decoding for lossless files (as there's more data). But still, it seems nice to have fast 5-3 IDWT anyways.For a large lossless file I have, it takes
bin/opj_decompress -i balloon-reversible.jp2 -o test.ppm -threads 0from printing "decode time: 588 ms" to "decode time: 559 ms", around a 5% speedup for decoding. It's not nothing, but much less than the other PR.I created that input file with
bin/opj_compress -i image.ppm -o balloon-reversible.jp2 -M 1, where image.ppm is balloon.jp2 in decompressed (and balloon.jp2 is the usual jp2 balloon test file).