Adjust/remove deprecated image preview #306
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| enable_debug); | ||
| } | ||
|
|
||
| $.fn.refresh_fm_layout = refresh_fm_layout; |
There was a problem hiding this comment.
I can't tell for certain from the context but I suppose this refresh is specific to the preview so that it can indeed go.
There was a problem hiding this comment.
Well spotted after revisiting the code it seems like this one is actually non-preview specific.
| @@ -961,7 +961,6 @@ __IS_VERIFYCERTS_COMMENTED__ <VirtualHost *:${PUBLIC_HTTP_PORT}> | |||
| RewriteCond %{REQUEST_URI} ^/favicon.ico$ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/(images|assets|public|.well-known)/ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/(seafmedia|seafhttp|seafile)/ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/paraview/ | |||
There was a problem hiding this comment.
This removal will likely break rewriting due to the trailing [OR] in the previous line.
| @@ -1420,7 +1403,6 @@ __IS_VERIFYCERTS_COMMENTED__ <VirtualHost *:${PUBLIC_HTTP_PORT}> | |||
| RewriteCond %{REQUEST_URI} ^/favicon.ico$ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/(images|assets|public|.well-known)/ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/(seafmedia|seafhttp|seafile)/ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/paraview/ | |||
| @@ -2072,7 +2038,6 @@ __IS_VERIFYCERTS_COMMENTED__ <VirtualHost *:${PUBLIC_HTTP_PORT}> | |||
| RewriteCond %{REQUEST_URI} ^/(wsgi|cgi)-bin/(autocreate|autologout|logout).py$ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/(images|assets|public|.well-known|openid|cgi-sid)/ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/(seafmedia|seafhttp|seafile)/ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/paraview/ | |||
| @@ -2674,7 +2623,6 @@ __IS_VERIFYCERTS_COMMENTED__ <VirtualHost *:${PUBLIC_HTTP_PORT}> | |||
| RewriteCond %{REQUEST_URI} ^/(wsgi|cgi)-bin/(autocreate|autologout|logout).py$ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/(images|assets|public|.well-known|openid|cgi-sid)/ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/(seafmedia|seafhttp|seafile)/ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/paraview/ | |||
| @@ -3587,7 +3519,6 @@ __IS_VERIFYCERTS_COMMENTED__ <VirtualHost *:${PUBLIC_HTTP_PORT}> | |||
| RewriteCond %{REQUEST_URI} ^/(wsgi|cgi)-bin/(autocreate|autologout|logout).py$ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/(images|assets|public|.well-known|openid|cgi-sid)/ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/(seafmedia|seafhttp|seafile)/ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/paraview/ | |||
| @@ -4185,7 +4100,6 @@ __IS_VERIFYCERTS_COMMENTED__ <VirtualHost *:${PUBLIC_HTTP_PORT}> | |||
| RewriteCond %{REQUEST_URI} ^/favicon.ico$ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/(images|assets|public|.well-known)/ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/(seafmedia|seafhttp|seafile)/ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/paraview/ | |||
There was a problem hiding this comment.
...and last copy of the same.
| @@ -961,7 +961,6 @@ Alias /status-events.json "/home/mig/state/wwwpublic/status-events.json" | |||
| RewriteCond %{REQUEST_URI} ^/favicon.ico$ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/(images|assets|public|.well-known)/ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/(seafmedia|seafhttp|seafile)/ [OR] | |||
| RewriteCond %{REQUEST_URI} ^/paraview/ | |||
There was a problem hiding this comment.
Just a reminder that this fixture file needs all the same updates after fixing the [OR] issue above in the template.
| for key in ('image_type', 'data_type'): | ||
| __type_map[key] = valid_alphanumeric | ||
|
|
||
| for key in ('offset', 'x_dimension', 'y_dimension', 'z_dimension'): |
There was a problem hiding this comment.
I think we may have other valid uses of the offset input arg, but AFAICT we do in fact have another duplicate offset handler in guess_type, so I guess it's alright.
jonasbardino
requested changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated and non-maintained image preview functionality along with it's helper modules