Support password/digest file for sharelinks to allow custom password or disabled password access #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to honor any auth passwords/digests files found in the sharelink home, for symmetry with auth keys files there. When complete those files can be used to set a custom password for sharelinks and to disable password access to achieve key-only setups.
jonasbardino
added this to the
Sharelink improvements and capability extensions milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work-in-progress to enable custom passwords or even completely disable password and anonymous https access in sharelinks.
So far it only adjusts griddaemons login to honor any auth passwords/digests files found in the sharelink home when building the login maps for sftp/webdavs/ftps daemons. This is similar with how auth keys files are already handled there. Empty or invalid password files result in no password login to fundamentally provide key-only access.
Similar adjustment are needed both in the PAM/NSS modules for sftpsubsys support and in the apache side of access to files in such sharelink file listings (
ls.py) and in directshare_redirectfile serving.When complete those password files can e.g. be written by the
sharelinksbackend and offer either a custom password for sharelinks or disable password access to achieve key-only setups.