-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing migration note for isEditor
to NodeApi.isEditor
#4017
add missing migration note for isEditor
to NodeApi.isEditor
#4017
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I note the internal API for Line 426 in e913541
This PR aims to avoid confusion for anyone else doing the upgrade. |
Good catch, could you instead update the changelog / |
You mean change the BREAKING_CHANGES.md to: - - `isEditor` -> `editor.api.isEditor`
+ - `isEditor` -> `NodeApi.isEditor` |
editor.api.isEditor
methodisEditor
to NodeApi.isEditor
@zbeyens have update the breaking changes to reflect the updates. Let me know if there's anything else |
Thanks! The changeset can be removed. |
No problem, thanks 😄 |
Checklist
yarn typecheck
yarn lint:fix
yarn test
yarn brl
yarn changeset