Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect shortcut keys for subscript and superscript plugins #4023

Merged
merged 4 commits into from
Jan 23, 2025
+7 −2
Merged

Fix incorrect shortcut keys for subscript and superscript plugins #4023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc50bc4
Fix incorrect shortcut keys for subscript and superscript plugins
ralphr123 Jan 22, 2025
a5dc7e9
Add changeset
ralphr123 Jan 22, 2025
9c50948
Revert yarn.lock
ralphr123 Jan 22, 2025
28205d7
Update forty-emus-repeat.md
zbeyens Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/forty-emus-repeat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@udecode/plate-basic-marks': patch
---

Fix editor shortcuts for subscript and superscript marks.
2 changes: 1 addition & 1 deletion packages/basic-marks/src/react/SubscriptPlugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const SubscriptPlugin = toPlatePlugin(
({ editor, type }) => ({
shortcuts: {
toggleSubscript: {
keys: [[Key.Mod, ',']],
keys: [[Key.Mod, 'comma']],
preventDefault: true,
handler: () => {
editor.tf.toggleMark(type, {
Expand Down
2 changes: 1 addition & 1 deletion packages/basic-marks/src/react/SuperscriptPlugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const SuperscriptPlugin = toPlatePlugin(
({ editor, type }) => ({
shortcuts: {
toggleSuperscript: {
keys: [[Key.Mod, '.']],
keys: [[Key.Mod, 'period']],
preventDefault: true,
handler: () => {
editor.tf.toggleMark(type, {
Expand Down
Loading