-
Notifications
You must be signed in to change notification settings - Fork 938
test #4712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test #4712
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @felixfeng33's task —— View job PR Review: testI've completed my review of this pull request. Here's my task list:
Review SummaryThis PR makes minimal changes to the development page, replacing a component with an embedded iframe. While the changes are simple, there are several concerns that should be addressed. Issues Found🔴 Critical Issues
🟡 Code Quality Issues
✅ Changeset and Changelog Status
Recommendations
File Changes Review
ConclusionThis PR appears to be a quick test or experiment that's not ready for production. The lack of context, security considerations, and proper implementation suggests this should either be:
Please address the critical security concerns and provide proper context before this can be approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| /// <reference types="next" /> | ||
| /// <reference types="next/image-types/global" /> | ||
| /// <reference types="next/navigation-types/compat/navigation" /> | ||
| import "./.next/types/routes.d.ts"; | ||
| import "./.next/dev/types/routes.d.ts"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore typed-route import to generated path
The change in next-env.d.ts now imports ./.next/dev/types/routes.d.ts, but Next generates typed route definitions under ./.next/types/routes.d.ts for both next dev and next build. The new path does not exist in a normal build so tsc and yarn typecheck will fail with “Cannot find module './.next/dev/types/routes.d.ts'”. This file is auto‑generated and should keep the default path to avoid build breakage.
Useful? React with 👍 / 👎.
| return ( | ||
| <main> | ||
| {/* <EditorViewClient /> */} | ||
| <MarkdownStreamDemo /> | ||
| {/* <MarkdownStreamDemo /> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused MarkdownStreamDemo import
page.tsx still imports MarkdownStreamDemo even though its usage is commented out. With the repo’s eslint configuration, this unused import will trigger a no-unused-vars error and cause yarn lint to fail. Either drop the import or render the component.
Useful? React with 👍 / 👎.
Checklist
yarn typecheckyarn lint:fixyarn testyarn brlyarn changeset