Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(link): fixes links with marks #6078

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

GormanDesign
Copy link

Changes Overview

The current logic always uses the event.target as the link, but when marks are present the event.target is the mark itself (ie , ). The change below uses the els array to find and assign the link instead of relying on the event.target

Implementation Approach

  1. Check if the event target is in fact a HTMLAnchorElement
  2. If it is not, use the els array to find and assign the link instead of relying on the event.target

Testing Done

Tested in application with dynamic user content.

Verification Steps

Manually verification and Cypress tests run in application.

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

#4777

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: d21452d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit d21452d
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/679cf10a37c9530008d9688b
😎 Deploy Preview https://deploy-preview-6078--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

@alexvcasillas
Copy link
Contributor

Hey @GormanDesign can we have a changeset here? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants