Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set rel on youtube embed link #6083

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

teamclouday
Copy link

Changes Overview

Add sameChannelRel option to youtube extension, according to the embed url parameter description.

Implementation Approach

Following the same pattern as other parameters.

Testing Done

Not sure how to write a test for this.

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: 95cad5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@tiptap/extension-youtube Major
@tiptap/core Major
@tiptap/extension-blockquote Major
@tiptap/extension-bold Major
@tiptap/extension-bubble-menu Major
@tiptap/extension-bullet-list Major
@tiptap/extension-character-count Major
@tiptap/extension-code-block-lowlight Major
@tiptap/extension-code-block Major
@tiptap/extension-code Major
@tiptap/extension-collaboration-cursor Major
@tiptap/extension-collaboration Major
@tiptap/extension-color Major
@tiptap/extension-document Major
@tiptap/extension-dropcursor Major
@tiptap/extension-floating-menu Major
@tiptap/extension-focus Major
@tiptap/extension-font-family Major
@tiptap/extension-gapcursor Major
@tiptap/extension-hard-break Major
@tiptap/extension-heading Major
@tiptap/extension-highlight Major
@tiptap/extension-history Major
@tiptap/extension-horizontal-rule Major
@tiptap/extension-image Major
@tiptap/extension-italic Major
@tiptap/extension-link Major
@tiptap/extension-list-item Major
@tiptap/extension-list-keymap Major
@tiptap/extension-mention Major
@tiptap/extension-ordered-list Major
@tiptap/extension-paragraph Major
@tiptap/extension-placeholder Major
@tiptap/extension-strike Major
@tiptap/extension-subscript Major
@tiptap/extension-superscript Major
@tiptap/extension-table-cell Major
@tiptap/extension-table-header Major
@tiptap/extension-table-row Major
@tiptap/extension-table Major
@tiptap/extension-task-item Major
@tiptap/extension-task-list Major
@tiptap/extension-text-align Major
@tiptap/extension-text-style Major
@tiptap/extension-text Major
@tiptap/extension-typography Major
@tiptap/extension-underline Major
@tiptap/html Major
@tiptap/pm Major
@tiptap/react Major
@tiptap/starter-kit Major
@tiptap/suggestion Major
@tiptap/vue-2 Major
@tiptap/vue-3 Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 95cad5e
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/67a4d4f509bf640008c2deb8
😎 Deploy Preview https://deploy-preview-6083--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@teamclouday
Copy link
Author

Btw I also think this code is wrong, because it skips the rest of url parameters configurations if the copied link has youtu.be, which is true in current youtube website when click on the share button

return `${getYoutubeEmbedUrl(nocookie)}${id}`

@teamclouday
Copy link
Author

teamclouday commented Feb 4, 2025

Also probably better to first parse the url using new URL(url), and then merge the new search params based on the configuration, with the existing ones, to avoid having multiple ? in the link.

I can create new PRs if necessary

Copy link
Contributor

@alexvcasillas alexvcasillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just left a minor nit in terms of following more closely the YouTube documentation for the embedded player parameters. Otherwise, looks great 👍🏻

We would also need a changeset for this addition :)

packages/extension-youtube/src/utils.ts Outdated Show resolved Hide resolved
@alexvcasillas
Copy link
Contributor

Also probably better to first parse the url using new URL(url), and then merge the new search params based on the configuration, with the existing ones, to avoid having multiple ? in the link.

I can create new PRs if necessary

Feel free to contribute with as what you think it would significantly improve the overall experience of the user for this particular extension :)

@teamclouday
Copy link
Author

Feel free to contribute with as what you think it would significantly improve the overall experience of the user for this particular extension :)

Sounds good! I'll create another PR after this one is merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants