-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to set rel on youtube embed link #6083
base: develop
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 95cad5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Btw I also think this code is wrong, because it skips the rest of url parameters configurations if the copied link has
|
Also probably better to first parse the url using I can create new PRs if necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just left a minor nit in terms of following more closely the YouTube documentation for the embedded player parameters. Otherwise, looks great 👍🏻
We would also need a changeset for this addition :)
Feel free to contribute with as what you think it would significantly improve the overall experience of the user for this particular extension :) |
Sounds good! I'll create another PR after this one is merged! |
Changes Overview
Add
sameChannelRel
option to youtube extension, according to the embed url parameter description.Implementation Approach
Following the same pattern as other parameters.
Testing Done
Not sure how to write a test for this.
Verification Steps
Additional Notes
Checklist
Related Issues