Ctests for individual schemes. #354
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: Physics Scheme Unit Tests (CTest) | ||
|
|
||
| on: [push, pull_request] | ||
|
Collaborator
There was a problem hiding this comment. How about this is triggered using the following:
Collaborator
There was a problem hiding this comment. I'm not sure that we want this to run on every push to save GitHub resources.
Author
There was a problem hiding this comment. these are very lightweight and wouldn't really be a limiting factor in my opinion. We should do it on PRs so that we know within the PR if it is failing before the PR is approved. |
||
|
|
||
| jobs: | ||
| ctests: | ||
|
Collaborator
There was a problem hiding this comment. Ditto more descriptive name here. |
||
| if: github.repository == 'NCAR/ccpp-physics' || github.repository == 'ufs-community/ccpp-physics' || github.repository == 'bbakernoaa/ccpp-physics' | ||
|
There was a problem hiding this comment. I think this should be either "only the authoritative repository" or "any repository".
Author
There was a problem hiding this comment. I agree. These are small enough it could any repository. |
||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y gfortran cmake | ||
|
Comment on lines
+14
to
+17
There was a problem hiding this comment. This may be ok for now, in the long run we need another option so that we have ESMF, w3emc, ip, bacio. We can probably piggyback on the container solution that @dustinswales is working on for running SCM from this repository.
Collaborator
There was a problem hiding this comment. These unit tests don't need ESMF or any other dependencies, just fortran and cmake. The CCPP SCM tests do need all of those other things, which is a pain to install/maintain on the GitHub runners, not to mention slow. So we are moving to containerized CI to give us total control, plus access to proprietary compilers. |
||
|
|
||
| - name: Build and run smoke and dust tests | ||
| run: | | ||
| cd physics/smoke_dust/tests | ||
| mkdir build | ||
| cd build | ||
| cmake .. | ||
| make | ||
| ctest --output-on-failure | ||
|
Collaborator
There was a problem hiding this comment. To make debugging easier when a test fails in the CI, would it be possible to add an |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change to something like "Smoke-Dust Unit Tests (CTest)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure