Skip to content

Small bug when not using photochemistry #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dustinswales merged 10 commits into from
Apr 29, 2026
Merged

Small bug when not using photochemistry #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c851dc5
Chagne to not using ozone physics DDT when not active
dustinswales Feb 4, 2026
b116d90
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
dustinswales Feb 24, 2026
0eaff25
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
dustinswales Mar 2, 2026
d520ac0
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
dustinswales Mar 19, 2026
e328c04
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
dustinswales Mar 30, 2026
90b2b11
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
dustinswales Apr 9, 2026
c6686ab
Bug in gcycle error message
dustinswales Apr 15, 2026
ea3184a
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
dustinswales Apr 20, 2026
53462ba
Merge branch 'feature/mpas_in_ufs' of https://github.com/dustinswales…
dustinswales Apr 20, 2026
3411caa
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
dustinswales Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion physics/Interstitials/UFS_SCM_NEPTUNE/GFS_phys_time_vary.fv3.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,17 +864,18 @@ subroutine GFS_phys_time_vary_timestep_init (
jday = 0
call w3doxdat(jdat,jdow,jdoy,jday)
rjday = jdoy + jdat(5) / 24.
if (rjday < ozphys%time(1)) rjday = rjday + 365.

!> - Update ozone concentration.
if (ntoz > 0) then
if (rjday < ozphys%time(1)) rjday = rjday + 365.

@NickSzapiro-NOAA NickSzapiro-NOAA Apr 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the context here but isn't this off by a day for leap years?

call find_photochem_time_index(ozphys%ntime, ozphys%time, rjday, n1, n2)

call ozphys%update_o3prog(jindx1_o3, jindx2_o3, ddy_o3, rjday, n1, n2, ozpl)
endif

!> - Update stratospheric h2o concentration.
if (h2o_phys) then
if (rjday < h2ophys%time(1)) rjday = rjday + 365.
call find_photochem_time_index(h2ophys%ntime, h2ophys%time, rjday, n1, n2)

call h2ophys%update(jindx1_h, jindx2_h, ddy_h, rjday, n1, n2, h2opl)
Expand Down
2 changes: 1 addition & 1 deletion physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ subroutine gcycle (me, nthrds, nx, ny, isc, jsc, nsst, tile_num, nlunit, fn_nml,
inquire (file=trim(fn_nml),exist=exists)
if (.not. exists) then
errflg = 1
errmsg = 'ERROR(gcycle): namelist file: ',trim(fn_nml),' does not exist.'
errmsg = 'ERROR(gcycle): namelist file: '//trim(fn_nml)//' does not exist.'
return
else
open (unit=nlunit, file=trim(fn_nml), action='READ', status='OLD', iostat=ios)
Expand Down
Loading