Skip to content

Updates to progomega option of saSAS convection scheme#3130

Merged
FernandoAndrade-NOAA merged 30 commits intoufs-community:developfrom
lisa-bengtsson:updraft
Mar 25, 2026
Merged

Updates to progomega option of saSAS convection scheme#3130
FernandoAndrade-NOAA merged 30 commits intoufs-community:developfrom
lisa-bengtsson:updraft

Conversation

@lisa-bengtsson
Copy link
Copy Markdown
Contributor

@lisa-bengtsson lisa-bengtsson commented Mar 6, 2026

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

This PR brings in improvements, cleaning and tuning of the prognostic updraft velocity parameterization under the progomega flag in saSAS. The new parameterization improves the representation of updrafts and cloud base mass-flux compared with lidar observations.

Commit Message:

* UFSWM - Update submodule pointer to UFSATM
  * UFSATM -  Update submodule pointer to ccpp-physics
    * ccpp-physics - Include new code under progomega option in saSAS convection

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation: Just tuning, cleaning, refinement of existing scheme

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@gspetro-NOAA gspetro-NOAA added Baseline Updates Current baselines will be updated. UFSATM There are changes to the UFSATM repository. CCPP There are changes to a CCPP repository. labels Mar 8, 2026
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Pre-testing required in PRs to Process Mar 8, 2026
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

gspetro-NOAA commented Mar 9, 2026

@lisa-bengtsson If work on this PR is complete, please make sure to run the full RT suite, preferably on Ursa, and push the logs and the test_changes.list file, which will show which baselines will change.

@lisa-bengtsson
Copy link
Copy Markdown
Contributor Author

@lisa-bengtsson If work on this PR is complete, please make sure to run the full RT suite, preferably on Ursa, and push the logs and the test_changes.list file, which will show which baselines will change.

@gspetro-NOAA I have now updated the logfile from Ursa and the test_changes.list I think the main CCPP PR still needs to be reviewed.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@gspetro-NOAA I have now updated the logfile from Ursa and the test_changes.list I think the main CCPP PR still needs to be reviewed.

Great, thanks! I'll see if I can prompt folks to review.

@gspetro-NOAA gspetro-NOAA moved this from Pre-testing required to Waiting for Reviews (subcomponent) in PRs to Process Mar 16, 2026
@gspetro-NOAA gspetro-NOAA added the On Deck This is the next PR in line for testing/merge. label Mar 19, 2026
@gspetro-NOAA gspetro-NOAA moved this from Waiting for Reviews (subcomponent) to Review in PRs to Process Mar 19, 2026
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@lisa-bengtsson Please sync with develop whenever you have a chance. We'd like to process your PR next. :)

@lisa-bengtsson
Copy link
Copy Markdown
Contributor Author

@gspetro-NOAA I have synced with develop in all the submodules, let me know if there's anything else I should do. Thanks!

@gspetro-NOAA gspetro-NOAA moved this from Review to Schedule in PRs to Process Mar 20, 2026
@gspetro-NOAA gspetro-NOAA added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. and removed On Deck This is the next PR in line for testing/merge. labels Mar 20, 2026
@lisa-bengtsson
Copy link
Copy Markdown
Contributor Author

Ok - I have synced this PR now, let me know if there is anything else I should do.

@FernandoAndrade-NOAA FernandoAndrade-NOAA added the In Testing The PR that is currently in testing stages label Mar 24, 2026
@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

We should be good to go for starting RTs, thank you! @gspetro-NOAA @BrianCurtis-NOAA

@gspetro-NOAA gspetro-NOAA removed the On Deck This is the next PR in line for testing/merge. label Mar 24, 2026
@gspetro-NOAA gspetro-NOAA removed the In Testing The PR that is currently in testing stages label Mar 25, 2026
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Testing has completed successfully on this PR. Leaving a note in the sub-PRs.

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

UFSATM is merged at 6327112

@FernandoAndrade-NOAA FernandoAndrade-NOAA merged commit 855243a into ufs-community:develop Mar 25, 2026
9 of 10 checks passed
@github-project-automation github-project-automation bot moved this from Schedule to Done in PRs to Process Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. CCPP There are changes to a CCPP repository. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. UFSATM There are changes to the UFSATM repository.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants