feat(ui5-tooling-modules): de-support AMD modules to ensure copyright…

… headers Fixes #1163
ui5-community · Feb 7, 2025 · 2439c28 · 2439c28
1 parent ce6bb38
commit 2439c28
Show file tree

Hide file tree

Showing 18 changed files with 47,258 additions and 43,843 deletions.
diff --git a/packages/ui5-tooling-modules/lib/middleware.js b/packages/ui5-tooling-modules/lib/middleware.js
@@ -233,7 +233,7 @@ module.exports = async function ({ log, resources, options, middlewareUtil }) {
 					debug && log.info(`Bundling took ${Date.now() - bundleTime} millis`);
 					bundleInfo.getEntries().forEach((entry) => {
 						if (entry.path) {
-							watcher.add(entry.path);
+							watcher?.add(entry.path);
 							debug && log.verbose(`[FSWATCHER] File ${entry.path} has been added`);
 						}
 					});

diff --git a/packages/ui5-tooling-modules/lib/rollup-plugin-amd-custom.js b/packages/ui5-tooling-modules/lib/rollup-plugin-amd-custom.js
diff --git a/packages/ui5-tooling-modules/lib/util.js b/packages/ui5-tooling-modules/lib/util.js
@@ -9,7 +9,6 @@ const commonjs = require("@rollup/plugin-commonjs");
 const json = require("@rollup/plugin-json");
 const nodePolyfills = require("rollup-plugin-polyfill-node");
 const nodePolyfillsOverride = require("./rollup-plugin-polyfill-node-override");
-const amdCustom = require("./rollup-plugin-amd-custom");
 const skipAssets = require("./rollup-plugin-skip-assets");
 const injectESModule = require("./rollup-plugin-inject-esmodule");
 const logger = require("./rollup-plugin-logger");
@@ -1078,7 +1077,6 @@ module.exports = function (log, projectInfo) {
 					commonjs({
 						defaultIsModuleExports: true,
 					}),
-					amdCustom(),
 					// node polyfills/resolution must happen after
 					// commonjs and amd to ensure e.g. exports is
 					// properly handled by those plugins
@@ -1261,7 +1259,13 @@ module.exports = function (log, projectInfo) {
 						options.afterPlugins.push(dynamicImports({ findPackageJson, keepDynamicImports }));
 						// when minifying the code, we add the terser plugin
 						if (minify) {
-							options.afterPlugins.push(require("@rollup/plugin-terser")());
+							options.afterPlugins.push(
+								require("@rollup/plugin-terser")({
+									output: {
+										comments: /^!/, // Keeps comments starting with "!"
+									},
+								}),
+							);
 						}
 						const nameOfModules = modules.map((module) => module.name);
 						//const millis = Date.now();

diff --git a/packages/ui5-tooling-modules/package.json b/packages/ui5-tooling-modules/package.json
@@ -25,7 +25,6 @@
     "timeout": "20s"
   },
   "dependencies": {
-    "@buxlabs/amd-to-es6": "^0.16.3",
     "@javascript-obfuscator/escodegen": "^2.3.0",
     "@rollup/plugin-commonjs": "^28.0.2",
     "@rollup/plugin-inject": "^5.0.5",