Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-tooling-modules] License header removed when using sheetjs with ui5-tooling-modules #1163

Open
marc4F opened this issue Feb 6, 2025 · 4 comments · Fixed by #1167
Open
Assignees

Comments

@marc4F
Copy link

marc4F commented Feb 6, 2025

Hello :)

When using the SheetJS library with the following dependency:

"dependencies": {
  "xlsx": "https://cdn.sheetjs.com/xlsx-0.20.3/xlsx-0.20.3.tgz"
}

the ui5-tooling-modules plugin (version ^3.20.6) appears to remove the license comment at the top of the xlsx.js file in the thirdparty folder. Specifically, the following license header is removed:

/*! xlsx.js (C) 2013-present SheetJS -- http://sheetjs.com */

To Reproduce

  1. Add the above dependency to your UI5 project.
  2. Build the project.
  3. Check the generated thirdparty folder and note that the license comment is missing from the top of xlsx.js.

Expected Behavior

The license header should remain at the top of the generated xlsx.js file to maintain legal and attribution requirements.

Additional Context

  • ui5-tooling-modules version: 3.20.6
  • The license comment is present in the original library but is missing after the UI5 build process.
@petermuessig
Copy link
Member

Thanks @marc4F - need to check what rollup can do here...

@petermuessig
Copy link
Member

Fixed with version 3.22.0

@marc4F
Copy link
Author

marc4F commented Feb 11, 2025

Hi @petermuessig

thanks for the fast response. But it seems to still remove the license info

Image

@petermuessig petermuessig reopened this Feb 13, 2025
@petermuessig
Copy link
Member

@marc4F - I need to check - BTW: did you scroll through the file - the copyright was somewhere in the middle of the file for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants