Skip paths for which path.to_obg() returns False. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am using graph peak caller on a haplotype indexed whole genome graph.
My vg files contain many paths corresponding to the haplotypes, including the reference path (chr1, chr2, etc).
When using graph_peak_caller find_linear_path to retrieve the reference interval, for some paths obg_interval is assigned to False by path.to_obg(). This results in an error when assigning obg_interval.name to path.name. Therefore, I added a check that skip such paths.
All the instances of this bug involves haplotype paths and not the reference path. This fix allowed me to retrieve my reference intervals without any problems.