Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 100 chars #2644

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Allow 100 chars #2644

merged 2 commits into from
Feb 6, 2025

Conversation

ujh
Copy link
Owner

@ujh ujh commented Feb 6, 2025

No description provided.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 64.02878% with 100 lines in your changes missing coverage. Please review.

Project coverage is 70.20%. Comparing base (00d9424) to head (d0b64ec).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ript/src/admin/pens-micro-clusters/withDistance.js 0.00% 5 Missing ⚠️
...rc/admin/pens-model-micro-clusters/withDistance.js 0.00% 5 Missing ⚠️
app/models/bots/pen_and_ink_suggestion.rb 0.00% 5 Missing ⚠️
...ript/src/admin/components/clustering/CreateRow.jsx 0.00% 4 Missing ⚠️
...ipt/src/admin/pens-micro-clusters/macroClusters.js 0.00% 4 Missing ⚠️
app/controllers/histories_controller.rb 0.00% 3 Missing ⚠️
app/javascript/color-mode.js 0.00% 3 Missing ⚠️
app/javascript/src/add-ink-button/app.jsx 57.14% 3 Missing ⚠️
...c/admin/pens-model-micro-clusters/macroClusters.js 0.00% 3 Missing ⚠️
app/models/macro_cluster.rb 50.00% 3 Missing ⚠️
... and 51 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2644      +/-   ##
==========================================
+ Coverage   70.09%   70.20%   +0.11%     
==========================================
  Files         289      289              
  Lines        4828     4762      -66     
  Branches      175      174       -1     
==========================================
- Hits         3384     3343      -41     
+ Misses       1426     1401      -25     
  Partials       18       18              
Flag Coverage Δ
javascript 43.69% <49.03%> (+0.14%) ⬆️
ruby 85.32% <72.98%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ujh ujh merged commit 1b9fbc9 into master Feb 6, 2025
5 of 6 checks passed
@ujh ujh deleted the allow-100-chars branch February 6, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant