Add Python 3.12+ support with ensure_setuptools#2205
Open
ozanayrikan wants to merge 1 commit intoultrafunkamsterdam:masterfrom
Open
Add Python 3.12+ support with ensure_setuptools#2205ozanayrikan wants to merge 1 commit intoultrafunkamsterdam:masterfrom
ozanayrikan wants to merge 1 commit intoultrafunkamsterdam:masterfrom
Conversation
Added Python 3.12+ support in ensure_setuptools with a warning and single RuntimeError for missing setuptools, prompting manual installation. Fixed LooseVersion NameError via global import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
ensure_setuptoolsinpatcher.pyto handle the missingdistutils.version.LooseVersionin Python 3.12+, wheredistutilsis removed, requiringsetuptools.logger.warningto alert users about the missingLooseVersionand Python 3.13’s lack ofdistutils.RuntimeErrorwith clear instructions to runpip install setuptoolsand a note suggesting Python 3.11 for nativedistutilssupport.NameErrorby makingLooseVersionglobal withglobal LooseVersion.Why:
Encountered errors in Python 3.13 due to
distutilsremoval, breakingLooseVersionimports inundetected_chromedriver. Users needed clear guidance to installsetuptools.Fixes
scrap_data.py(web scraper) usingundetected_chromedriveron Python 3.13 (Windows, June 7, 2025, 9:11 PM +03).