Conversation
added 2 commits
March 13, 2025 16:32
… handling. Also the capsule hand prefab(s) lost its reference to the sphere mesh, so I've reset it
…s/Tracking/Core/Runtime/Plugins/MacOS/libLeapC.5.dylib: convert to Git LFS
9 tasks
Member
|
These changes look good to me, however why are the dylibs including |
Contributor
Author
|
I've tried to tidy up the libs / names. This appears to work on the Apple Silicon Mac I have but I'd appreciate someone else checking it works on theirs. Unity does some caching of the binaries sometimes. |
Member
Can we not |
Contributor
Author
|
I originally went down that route with Peter and it seemed to become more complex than you might imagine... |
rblenkinsopp
approved these changes
Mar 21, 2025
Member
rblenkinsopp
left a comment
There was a problem hiding this comment.
Happy then if alternative routes have been investigated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do this PR after: #1686, as that PR is to merge into this branch (my mistake).
Fixes a few issues on my Apple Silicon MacBook
[1] Capsule hand sphere mesh was not set in the prefabs, generating errors. Not sure why this is only seen on a Mac and not in Windows,
[2] Binaries for Apple Silicon were not present and/or signed. Added these.
[3] Improved some error handling.
Contributor Tasks
Reviewer Tasks
Related JIRA Issues
If this MR closes any JIRA issues list them below in the form
Closes PROJECT-#Pull Request Templates
Switch template by going to preview and clicking the link - note it will not work if you've made any changes to the description.
You are currently using: default.md
Note: these links work by overwriting query parameters of the current url. If the current url contains any you may want to amend the url with
&template=name.mdinstead of using the link. See query parameter docs for more information.