Skip to content

Fix malformed Natural Earth HTML - #27

Merged
glenn-jocher merged 2 commits into
mainfrom
update-format-headers-redirects-20260612201348
Jun 12, 2026
Merged

Fix malformed Natural Earth HTML#27
glenn-jocher merged 2 commits into
mainfrom
update-format-headers-redirects-20260612201348

Conversation

@glenn-jocher

@glenn-jocher glenn-jocher commented Jun 12, 2026

Copy link
Copy Markdown
Member

Summary

  • fix malformed Natural Earth logo alt/title attributes
  • balance obvious paragraph and page wrapper tags in the affected Natural Earth README HTML files

Validation

  • npx --yes prettier --parser html mapping/ne_10m_admin_0_countries_lakes/ne_10m_admin_0_countries_lakes.README.html >/dev/null
  • npx --yes prettier --parser html mapping/ne_10m_admin_0_countries/ne_10m_admin_0_countries.README.html >/dev/null
  • npx --yes prettier --parser html mapping/ne_10m_admin_0_boundary_lines_land/ne_10m_admin_0_boundary_lines_land.README.html >/dev/null
  • git diff --check

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

🧹 This PR is a documentation and formatting cleanup that modernizes bundled HTML/Markdown files, improves readability, and standardizes wording across the repository and included third-party export_fig docs/code comments.

📊 Key Changes

  • Reformatted several large Natural Earth HTML README files in mapping/ for cleaner indentation and more consistent structure. 📄
  • Applied small Markdown cleanup in the main README.md, mainly spacing and list formatting improvements. ✨
  • Updated the bundled thirdparty/altmany-export_fig-cafc7c5/README.md to improve table alignment, list formatting, code block layout, and wording consistency. 🛠️
  • Standardized language in the export_fig third-party files by changing terms like “colour”, “greyscale”, “initialise”, and “dialogue” to “color”, “grayscale”, “initialize”, and “dialog`. 🇺🇸
  • Adjusted comments and one user-facing error message in export_fig.m from “recognised” to “recognized,” without changing functionality. 🔍

🎯 Purpose & Impact

  • Improves maintainability by making documentation and embedded HTML files easier to read, review, and edit. 👍
  • Creates a more consistent user experience across repository docs and bundled third-party materials. 📚
  • Makes third-party helper documentation clearer for MATLAB users working with figure export tools. 🖼️
  • Appears to be non-functional overall: no algorithm, API, or feature behavior changes are introduced, so impact on existing users should be minimal and low risk. ✅

@UltralyticsAssistant UltralyticsAssistant added bug Something isn't working fixed Bug has been resolved priority: low Low urgency; can wait behind higher-priority work. labels Jun 12, 2026
@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/functions-matlab 🚀 PR! This is an automated message to help with review readiness, and an engineer will assist shortly. Please review the checklist below for smooth integration:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/functions-matlab main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

The PR looks clean. The changes are narrowly scoped to fixing malformed HTML in the bundled Natural Earth README files, and the updated tag balancing appears consistent across all three files. I did not find any genuine issues in the modified lines.

@glenn-jocher
glenn-jocher merged commit 7ba90f4 into main Jun 12, 2026
4 checks passed
@glenn-jocher
glenn-jocher deleted the update-format-headers-redirects-20260612201348 branch June 12, 2026 20:37
@UltralyticsAssistant

Copy link
Copy Markdown
Member

Merged! 🎉 Thanks @glenn-jocher for this thoughtful cleanup and polish across the docs and bundled third-party materials.

As Leonardo da Vinci said, “Details make perfection, and perfection is not a detail.” This PR is a great example of that idea in practice—improving readability, consistency, and maintainability without changing functionality, while making the repository clearer and more welcoming for everyone who works with it.

Really appreciate the care behind these refinements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fixed Bug has been resolved priority: low Low urgency; can wait behind higher-priority work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants