Fix ecef2lla altitude conversion - #28
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
The PR is clean. The updated WGS84 eccentricity handling in ecef2lla.m matches the standard ECEF-to-LLA formulation, and I did not find any verified regressions or actionable issues in the changed lines.
|
🚀 Merged — thank you @glenn-jocher! “Measure what is measurable, and make measurable what is not so.” — Galileo Galilei This update brings that spirit to Your contribution strengthens the accuracy and trustworthiness of this function for everyone building on Ultralytics tools. Much appreciated! |
Fixes #20.
This corrects the WGS84 eccentricity terms in
transformations/ecef2lla.mso latitude and altitude use the same formulation as the referenced implementation.Validation:
Deleted: incorrect extra squaring of first and second eccentricity terms in
ecef2lla.m.🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improves the accuracy of ECEF-to-LLA coordinate conversion by correcting eccentricity calculations in
ecef2lla.m🌍📊 Key Changes
eseparately, then computes squared eccentricityesfrom it ✅epto use the square root as expected 📐esinstead ofes^2, preventing incorrect scaling in the denominator 🛠️🎯 Purpose & Impact