Skip to content

Update ci.yml to run tests dir directly#51

Merged
glenn-jocher merged 1 commit intomainfrom
glenn-jocher-patch-1
Jan 16, 2025
Merged

Update ci.yml to run tests dir directly#51
glenn-jocher merged 1 commit intomainfrom
glenn-jocher-patch-1

Conversation

@glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 16, 2025

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced test coverage in the CI workflow for improved reliability ✅

📊 Key Changes

  • Updated the CI workflow to run all Python test files (tests) instead of a single test file (tests/test_module1.py).

🎯 Purpose & Impact

  • Purpose: Ensures a more comprehensive validation of the codebase by including all available tests during the CI process.
  • Impact: Improves code quality and reduces the risk of undetected bugs, leading to a more robust and stable project for all users 🚀.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Jan 16, 2025
@UltralyticsAssistant
Copy link
Member

👋 Hello @glenn-jocher, thank you for submitting an ultralytics/template 🚀 PR! To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/template main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🌟

This is an automated response to assist you with the PR process, but don’t worry, an Ultralytics engineer will review and provide further feedback soon. 🚀

@glenn-jocher glenn-jocher merged commit e793e64 into main Jan 16, 2025
8 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch January 16, 2025 14:07
@UltralyticsAssistant
Copy link
Member

🎉 Your PR has been merged, @glenn-jocher! 🌟

Thank you for your thoughtful work on enhancing test coverage in our CI workflow. Your contribution ensures a stronger, more reliable foundation for the project, benefiting everyone who depends on it. 🚀

As Leonardo da Vinci put it, "Details make perfection, and perfection is not a detail." By ensuring all tests are run, you've pushed us closer to perfection—one detail at a time. Your efforts truly make a difference. 🙌

Let’s keep building greatness together! 🔧✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops GitHub Devops or MLops enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants