Skip to content

wip: add more field types and deal with Enum in facets #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 37 commits into
base: master
Choose a base branch
from
Draft

wip: add more field types and deal with Enum in facets #2868

wants to merge 37 commits into from

Conversation

yohanboniface
Copy link
Member

@yohanboniface yohanboniface commented Aug 15, 2025 •
edited by davidbgk
Loading

fix #2843
fix #1570

Todo:

  • quick edit for filters from the browser
  • tests for undo/redo of field rename/delete
  • make filters orderable
  • find a way to edit the field type from the number edit form => add a link to go from filter to field and vice versa
  • adapt the input in the feature form according to the field type (if number, enum, date, etc.)
  • deal with parsing French dates (dd-mm-yyyy)
  • add a "field, filters and sort" fieldset
  • update widget list according to field type (do not show minmax for boolean, for example)
  • rename facet to filter in code and data (or vice-versa)
  • make filters work for boolean
  • add type=button on filters quick edit buttons
  • list datalayer AND map fields in the tableeditor
  • decide what to do when deleting a field with a related filter (delete filter or prevent deleting field?)
  • make clearer that there are fields on the map and on the layers (see Have a sense of deepness affordance for the side panel (+navigation!) #1156)
  • test for edit/rename where field exist both on datalayer and map

@yohanboniface yohanboniface force-pushed the enum-field-type branch 3 times, most recently from 7fd9b95 to 971e780 Compare August 22, 2025 14:54
@davidbgk davidbgk mentioned this pull request Sep 9, 2025
Open
@yohanboniface yohanboniface force-pushed the enum-field-type branch 2 times, most recently from 7f0e474 to 3a5102f Compare September 17, 2025 14:11
yohanboniface and others added 23 commits September 22, 2025 19:03
@yohanboniface @davidbgk
wip: add more field types and deal with Enum in facets
aa096bc 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface
wip: add FieldManager and refactor facets
e4be9c8
@yohanboniface
wip: add fields management on the Umap object
bc8b9ce
@yohanboniface
wip: allow to switch from filter dialog to field dialog and vice-versa
f3bff11
@yohanboniface
wip: customize field input according to type and add icon
70bbc0d
@yohanboniface
fix: fix reordering fields
337d95f
@yohanboniface
wip: keep order on field rename
c86852a 
Map will always respect the insertion order, so when updating
a field without rename it will update the existing entry, but when
the key changes, so it is like a new entry.
@yohanboniface
wip: allow to reorder fields
5282467
@yohanboniface
wip: make sure fields are saved after changing their type
02c8688
@yohanboniface
wip: introduce DateTimeInput
ce2b86c
@yohanboniface @davidbgk
wip: merge fieldsets for fields, filters and keys management
9f34f9d 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface @davidbgk
wip: fix filters update
f763376 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface @davidbgk
wip: poor man way of dealing with French formatted dates
896bd37 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface @davidbgk
wip: make sure we can undo a field rename
e75aa62 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface @davidbgk
wip: fix tests
e1f1d2c 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface @davidbgk
wip: allow to edit filter from the browser
9196c06 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface @davidbgk
wip: add "+" icon to "add filter" button
6e1f0aa 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface @davidbgk
wip: move Facet fields to facets module
abdef77 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface @davidbgk
wip: add button to create new filter from browser
c332b9b 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface
wip: do not fail when filtering a feature with a field from another l…
a521a3a 
…ayer
@yohanboniface @davidbgk
wip: rename Facet to Filter
63fb1af 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface @davidbgk
wip: add alert of type warning
0ff5760 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface @davidbgk
wip: allow to set filters on a datalayer
fd1e16d 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface yohanboniface mentioned this pull request Sep 22, 2025
Open
davidbgk and others added 5 commits September 23, 2025 11:43
@davidbgk @yohanboniface
fix: disable add filter button when there is no field
e95869a 
Co-authored-by: Yohan Boniface <[email protected]>
@yohanboniface
feat: add butons to open layer edit and table panels from feature panel
8e7fe75 
fix #2927
@davidbgk
feat: add buttons to open layer edit and table panels from feature pa…
5076817 
…nel (#2945)

fix #2927

CSS change is a bit violent, let's check that together :)
@yohanboniface
feat: add a message when user is logged and anonymous owner to attach…
7315cc4 
… map (#2948)
@yohanboniface
fix: do not try to open a dialog when one is closing
66e9fe2 
This created a bug when clicking on "Add a filter for this field",
which is calling "dialog.accept()" and then opening a new dialog.
In this case, the new dialog opens before the "close" event has
been sent, so it catches it wrongly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Technical help] Filter keys pulled from multiple properties Multiple values for facet search
2 participants
@yohanboniface @davidbgk